use smart pointers ?

handle errors and exceptions

extend code coverage

Member o2::ccdb::CcdbApi::deleteObject (std::string const &path, long timestamp=-1) const

Raise an exception if no such object exist.

Member o2::ccdb::CcdbApi::list (std::string const &path="", bool latestOnly=false, std::string const &returnFormat="text/plain", long createdNotAfter=-1, long createdNotBefore=-1) const

accept should use an enum class.

Member o2::ccdb::CcdbApi::truncate (std::string const &path) const

Raise an exception if no such object exist.

Member o2::math_utils::getStatisticsData (const T *arr, const size_t nBins, const double xMin, const double xMax)

make return type templated?

Member o2::math_utils::median (std::vector< T > v)

Is there a better way to do this?

Struct o2::math_utils::StatisticsData

make type templated?

use Vc

Member o2::tpc::BOOST_AUTO_TEST_CASE (GEMamplification_test)

should be more restrictive

Member o2::tpc::BOOST_AUTO_TEST_CASE (Mapper_complex_test1)

here there should be no mirroring necessary!

check CRU

Member o2::tpc::CalArray< T >::getValue (const size_t row, const size_t pad) const

might need check for row, pad or position limits

Member o2::tpc::CalArray< T >::setValue (const size_t row, const size_t pad, const T &value)

might need check for row, pad or position limits

Member o2::tpc::CalDet< T >::getValue (const ROC roc, const size_t row, const size_t pad) const

return value of T& not possible if a default value should be returned, e.g. T{}: warning: returning reference to temporary

Class o2::tpc::CalibTreeDump

At present this will only work for the PadSubset type ROC

Member o2::tpc::CDBInterface::getObjectFromCDB (std::string_view path)

Consider removing in favour of calling directly the manager::get method.

Member o2::tpc::CDBInterface::getSpecificObjectFromCDB (const std::string_view path, long timestamp=-1, const std::map< std::string, std::string > &metaData=std::map< std::string, std::string >())

Consider removing in favour of calling directly the manager::get method.

Member o2::tpc::Mapper::getPadNumberInPartition (int partition, int row, int pad) const

add check for row and pad limits

Member o2::tpc::Mapper::getPadNumberInRegion (CRU cru, int row, int pad) const

add check for row and pad limits

Member o2::tpc::Mapper::getPadNumberInROC (const PadROCPos &rocPadPosition) const

add check for row and pad limits

Member o2::tpc::Mapper::GlobalToLocal (const GlobalPosition3D &pos, const double alpha)

: Lookup over sector number

Member o2::tpc::Mapper::GlobalToLocal (const GlobalPosition2D &pos, const Sector sec)

: Lookup over sector number

Member o2::tpc::Mapper::GlobalToLocal (const GlobalPosition2D &pos, const double alpha)

: Lookup over sector number

Member o2::tpc::Mapper::GlobalToLocal (const GlobalPosition3D &pos, const Sector sec)

: Lookup over sector number

Member o2::tpc::PadRegionInfo::isInRegion (float localX, float border=0.f) const

check function

Member o2::tpc::ParameterGEM::Geometry [4]

Remove hard-coded number of GEMs in a stack

O2ParamDef takes no std::vectors/arrays, therefore the c-style

Member o2::tpc::rawreader::RawReaderCRUEventSync::getNumberOfEvents (CRU) const

extract correct number

Member o2::tpc::SAMPAProcessing::getShapedSignal (float ADCsignal, float driftTime, std::vector< float > &signalArray) const

the size of the array should be retrieved from ParameterElectronics::getNShapedPoints()

Member o2::tpc::TrackResiduals::getSmoothEstimate (int iSec, float x, float p, float z, std::array< float, ResDim > &res, int whichDim=0)

correct use of the symmetric matrix should speed up the code

Member o2::tpc::TrackResiduals::selectKthMin (const int k, std::vector< float > &data) const

Can probably be replaced by std::nth_element(), need to check which one is faster All smaller values will be placed in before it in arbitrary order, all large values behind it in arbitrary order.